Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add project filter to feature-toggle-list-builder #5099

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

andreas-unleash
Copy link
Contributor

@andreas-unleash andreas-unleash commented Oct 19, 2023

Adds forProject filter to FeatureToggleQueryBuilder
Filters playground results for an array of projects

Closes # 1-1525

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 11:58am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 11:58am

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Question: so this bug got introduced when we started splitting the stores?

@andreas-unleash
Copy link
Contributor Author

Nice. Question: so this bug got introduced when we started splitting the stores?

Yes, looks like it - tried with flag off and the clientFeatureToggleStore returns correct results

@andreas-unleash andreas-unleash merged commit 6760fc0 into main Oct 19, 2023
6 checks passed
@andreas-unleash andreas-unleash deleted the fix/playground_returns_all_projects branch October 19, 2023 12:05
@FredrikOseberg
Copy link
Contributor

Nice. Question: so this bug got introduced when we started splitting the stores?

Yes, looks like it - tried with flag off and the clientFeatureToggleStore returns correct results

Interesting, thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants